-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update npm to 5.4.2 #15486
deps: update npm to 5.4.2 #15486
Conversation
I don't know if
|
I found the problem. The CHECK is triggered by a call from this[_handle].init(opts.windowBits || constants.Z_DEFAULT_WINDOWBITS,
level,
opts.memLevel || constants.Z_DEFAULT_MEMLEVEL,
strategy,
opts.dictionary) The library is directly calling the internal function with 5 arguments. The function's signature was changed four months ago from 4/5 arguments to 7 in add4b0a (zlib: improve performance). |
|
I guess that might be the root cause of #14161 then … sigh. |
@targos could you open an issue on minizlib with the findings? |
Given that #13322 hasn't landed on 8.x, could this be retargeted to 8.x for now? I know it's not ideal for npm on 8.x to be ahead of |
This LGTM -- would be good for @iarna to eyeball it too. This includes three npm releases, one of which is pretty big (5.4.0). Changes of Note
Changelogs |
This includes three npm releases, one of which is pretty big (5.4.0). Changes of Note * Significant performance boost for installations from cache (~10%+) * A number of bugfixes for important and severe bugs affecting installation on all supported platforms, but particularly noticeable on Windows. * More Windows-related fixes for `npx`. * [nodejs#17844](npm/npm#17844) Make package-lock.json sorting locale-agnostic. This will cause some users to see seemingly spurious diffs on their pkglocks if they were using previous versions of npm5, because, for example, `JSONStream` is sorted into a different location. This is fine and will go away as people upgrade. Changelogs * [`v5.4.0`](https://github.com/npm/npm/releases/tag/v5.4.0) * [`v5.4.1`](https://github.com/npm/npm/releases/tag/v5.4.1) * [`v5.4.2`](https://github.com/npm/npm/releases/tag/v5.4.2)
ping regarding getting this to work on master |
@targos is there a PR to replace this? |
@MylesBorins No. There is no stable npm version that fixes the zlib issue at the moment. |
@targos this should likely be kept open then in case we end up reverting the zlib fix |
If that happens, we should update to the current version. It's not difficult to do. Feel free to ping me in case I miss it. |
Followed the guide to update npm to 5.4.2.
/cc @nodejs/npm @zkat @Fishrock123
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
deps